----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34336 -----------------------------------------------------------
I agree with the previous comment. It would have been better if uploaded as two separate patches: one for the prep work pre-move, and one for the move itself. It'd make things easier to review. Also that's how one should do its commits in that context: one commit for the dependency adjustments and one for the move (it's easier when hunting bugs or reading history later on). staging/kwidgets/src/paged/kpageview_p.cpp <http://git.reviewboard.kde.org/r/110997/#comment25226> This include should go away too. staging/kwidgets/src/paged/kpageview_p.cpp <http://git.reviewboard.kde.org/r/110997/#comment25227> I'd expect PM_IconViewIconSize here. It's a list view alright but we use larger icons in there like for an icon view. staging/kwidgets/src/paged/kpageview_p.cpp <http://git.reviewboard.kde.org/r/110997/#comment25228> ditto - Kevin Ottens On June 13, 2013, 2:57 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110997/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 2:57 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Moved KPage* > > Also ported the KPageListViewDelegate from using KIconLoader to get the icons > size to QStyle. This makes it not possible to react to changes in the icon > themes which shouldn't happen that often, and cuts a dependency instead. > > > Diffs > ----- > > kdeui/CMakeLists.txt 46196b4 > kdeui/dialogs/kassistantdialog.h 373e6cf > kdeui/dialogs/kconfigdialog.h ea342ac > kdeui/paged/kpagedialog.h 77a58d0 > kdeui/paged/kpagedialog.cpp 542d6a2 > kdeui/paged/kpagedialog_p.h 3893ba9 > kdeui/paged/kpagemodel.h 6645c4e > kdeui/paged/kpagemodel.cpp 5e5cfa7 > kdeui/paged/kpagemodel_p.h 6466f64 > kdeui/paged/kpageview.h 2d9fbe1 > kdeui/paged/kpageview.cpp 6648e34 > kdeui/paged/kpageview_p.h 6404cd6 > kdeui/paged/kpageview_p.cpp 42bdfe3 > kdeui/paged/kpagewidget.h 6cebef7 > kdeui/paged/kpagewidget.cpp 7bbfeb2 > kdeui/paged/kpagewidget_p.h 6eeaeccb > kdeui/paged/kpagewidgetmodel.h 0769a48 > kdeui/paged/kpagewidgetmodel.cpp c5f6e41 > kdeui/paged/kpagewidgetmodel_p.h 40c5fac > kdeui/tests/CMakeLists.txt 8746397 > kdeui/tests/kpagedialogtest.h a5e9be5 > kdeui/tests/kpagedialogtest.cpp b0e8efd > kdeui/tests/kpagewidgettest.h 206255b > kdeui/tests/kpagewidgettest.cpp a767401 > kio/CMakeLists.txt 6af7b6d > kutils/CMakeLists.txt 0276030 > staging/kwidgets/src/CMakeLists.txt 03a7d7a > staging/kwidgets/src/paged/kpagedialog.h PRE-CREATION > staging/kwidgets/src/paged/kpagedialog.cpp PRE-CREATION > staging/kwidgets/src/paged/kpagedialog_p.h PRE-CREATION > staging/kwidgets/src/paged/kpagemodel.h PRE-CREATION > staging/kwidgets/src/paged/kpagemodel.cpp PRE-CREATION > staging/kwidgets/src/paged/kpagemodel_p.h PRE-CREATION > staging/kwidgets/src/paged/kpageview.h PRE-CREATION > staging/kwidgets/src/paged/kpageview.cpp PRE-CREATION > staging/kwidgets/src/paged/kpageview_p.h PRE-CREATION > staging/kwidgets/src/paged/kpageview_p.cpp PRE-CREATION > staging/kwidgets/src/paged/kpagewidget.h PRE-CREATION > staging/kwidgets/src/paged/kpagewidget.cpp PRE-CREATION > staging/kwidgets/src/paged/kpagewidget_p.h PRE-CREATION > staging/kwidgets/src/paged/kpagewidgetmodel.h PRE-CREATION > staging/kwidgets/src/paged/kpagewidgetmodel.cpp PRE-CREATION > staging/kwidgets/src/paged/kpagewidgetmodel_p.h PRE-CREATION > staging/kwidgets/tests/CMakeLists.txt f173b80 > staging/kwidgets/tests/kpagedialogtest.h PRE-CREATION > staging/kwidgets/tests/kpagedialogtest.cpp PRE-CREATION > staging/kwidgets/tests/kpagewidgettest.h PRE-CREATION > staging/kwidgets/tests/kpagewidgettest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110997/diff/ > > > Testing > ------- > > Everything builds, the test seems good. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
