> On June 26, 2013, 9:31 p.m., Albert Astals Cid wrote: > > We should add a #warning or an epic item or something about the fact that > > "it doesn't work" as i noted in my first comment in the review.
I added one, what do you think? http://community.kde.org/Frameworks/Epics/kdelibs_cleanups - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111178/#review35151 ----------------------------------------------------------- On June 26, 2013, 11:27 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111178/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 11:27 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > While looking at the code, it seems clear that it was something we all knew > we had to think about but it was being delayed. > Before I asked Andrea why he was stuck on so many tasks and one of them was > the move of the KSwitchLanguageDialog (KLanguageButton epic). > > What we did was to port the code in the dialog to read the values from > QLocale, relying on KLocalizedStrings' hook to initialize QLocale properly. > So we added that hook that reads the configuration that knows what language > should be used to override the settings that Qt will use, which is the > LANGUAGE env var. > > NOTE: we removed the code that, after saying that the application should be > restarted, tries to change the language on the fly. It didn't work well (the > new things were translated, but not the old things). > > This is an important change, because: > - We use QLocale (thus $LANGUAGE env var) to define what language is being > used > - We will have to make sure how to map from QLocale naming to KDE naming (see > all_language.desktop). > - The languages KCM and KDE (kded, plasma, startkde... one of those) > initialization will have to make sure that LANGUAGE will be correctly set in > the KDE sessions > > Thoughts? > > Albert and Aleix > > > Diffs > ----- > > kdeui/dialogs/kswitchlanguagedialog_p.cpp 7f5fe95 > > Diff: http://git.reviewboard.kde.org/r/111178/diff/ > > > Testing > ------- > > not much > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
