----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110858/#review35560 -----------------------------------------------------------
Ship it! Looks good. Please commit, after fixing the two small things I found. If you don't have an account, please tell me and I'll push the changes. makeobj <http://git.reviewboard.kde.org/r/110858/#comment26109> We does not -> We don't makeobj <http://git.reviewboard.kde.org/r/110858/#comment26110> I see a difference between type -p and command -v here: for a shell alias that has the same name as an executable, type -p will find the executable while command -v will find the alias. But ok, it probably doens't matter here with non-interactive shells. makeobj <http://git.reviewboard.kde.org/r/110858/#comment26111> messed up indentation - David Faure On July 3, 2013, 10:05 p.m., Vadim Zhukov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110858/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 10:05 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Many KDE development scripts were written in a hurry and are: > > * unportable, e.g.: using bash instead of sh > * unreliable, e.g.: using of $* instead of $@ in shell scripts > * unsecure, e.g.: using open($file) idiom in Perl scripts > > I tweaked most obvious stuff that I found. This patch allows to better > integrate KDE development process into OpenBSD ecosystem, and, probably, in > ecosystem of other OSes. Not saying about getting more reliable results for > non-usual cases, such as filenames with non-ASCII-alphanum-characters in them. > > Given that KDE5 is coming, I think it's a good time to improve some core > stuff. :) > > > Diffs > ----- > > adddebug 782db52 > astyle-kdelibs 0450e8a > build-progress.sh 64247fc > cheatmake 9659a6c > colorsvn 84dec6b > cvsaddcurrentdir 503c7f3 > cvsblame bd3635e > cvslastlog d1b4581 > draw_lib_dependencies 1db6ef6 > kf5/functionUtilkde.pm 79b6547 > makeobj 4c9cca8 > nonsvnlist f94c3e8 > optimizegraphics c5f79b2 > package_crystalsvg 1502da2 > qt4/adapt-kconfiggroupsaver.pl ccd0e4e > qt4/adapt-to-kde4-api.pl 8364ef4 > qt4/adapt-to-new-kconfig2.pl b0e660f > qt4/adapt-to-new-kdebug-api.pl cf96261 > qt4/adapt-to-qt4-api.pl c225c62 > qt4/convert-bad-qdatastream.pl 779b0a0 > qt4/convert-display.pl 2c971b6 > qt4/convert-find-to-indexof.pl f732684 > qt4/convert-kgenericfactory.pl f8355bd > qt4/convert-killtimers.pl 60be59e > qt4/convert-kinstance.pl ca3d590 > qt4/convert-kkeydialog.pl f5581b4 > qt4/convert-kmimetype-pixmap.pl 003c9fb > qt4/convert-kstringhandler.pl 0b42bc5 > qt4/convert-newq4headers.pl 57c5148 > qt4/convert-q3cstring.pl a6a1919 > qt4/convert-qboxlayout.pl 564e197 > qt4/convert-qgridlayout.pl 367dca0 > qt4/convert-qiodevice_at.pl ff1ae8f > qt4/convert-qlabel.pl 4f0f3c4 > qt4/convert-qstringlatin1.pl 76f3de6 > qt4/convert-qvhbox.pl 7ab1afa > qt4/convert-signal.pl be50e9d > qt4/fix-link.pl 34ae20b > qt4/functionUtilkde.pm 79b6547 > qt4/icons-kde3tokde4-renamer/icons-kde3to4-renamer.sh 97cecd1 > qt4/remove-qt3-support.pl 0e34b8a > qt4/replaceAddRowSpacing.sh a86087f > qt4/replaceRenamedDeprecated.sh fa7cd06 > qt4/search-qstringlist.sh 2601441 > qt4/search-qwhatsthis.sh a34857c > qt4/search-registeredApplications.sh 31911ba > svn-clean 3c698bd > svn2log.sh ef78f56 > svnaddcurrentdir 53eb384 > svnforwardport f8dd9d6 > svnversions fbdca03 > unsercmake 24170ab > wcgrep 477bab5 > > Diff: http://git.reviewboard.kde.org/r/110858/diff/ > > > Testing > ------- > > Light tested on OpenBSD-CURRENT, from KDE 4.10.1 till 4.10.4. As I'm not a > KDE developer, this definitely needs more precise look. > > > Thanks, > > Vadim Zhukov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
