----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111493/#review35904 -----------------------------------------------------------
Looks ok. Beside that, the same comments as for kservice. Thanks a lot :-) - Alexander Neundorf On July 12, 2013, 1:19 p.m., Benjamin Port wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111493/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 1:19 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > In order to have all frameworks using the same name policy (i.e. use > CamelCase for libraries names) rename kwidgets framework lib to KWidgets > > > Diffs > ----- > > interfaces/kimproxy/library/CMakeLists.txt 5bc4b4d > interfaces/kmediaplayer/kfileaudiopreview/CMakeLists.txt fa83d78 > kdeui/CMakeLists.txt 3ca2e13 > kdewidgets/CMakeLists.txt 1f72c6f > kfile/CMakeLists.txt 765266c > kio/CMakeLists.txt c5cc280 > kio/kssl/kcm/CMakeLists.txt fa75e53 > kio/tests/CMakeLists.txt a0d7e88 > kioslave/http/kcookiejar/CMakeLists.txt 533068f > knewstuff/knewstuff3/CMakeLists.txt 4118ea7 > knotify/config/CMakeLists.txt db7c8d7 > knotify/tests/CMakeLists.txt 57e2a2d > kparts/CMakeLists.txt da398e9 > kutils/CMakeLists.txt 60da2ac > staging/kcompletion/src/CMakeLists.txt b125459 > staging/kde4support/src/CMakeLists.txt 96ba1ad > staging/kemoticons/src/core/CMakeLists.txt 1e375a7 > staging/kiconthemes/src/CMakeLists.txt 3cb795c > staging/kinterprocesswindowing/src/CMakeLists.txt 1c18f57 > staging/ktextwidgets/src/CMakeLists.txt 6b3c09f > staging/kwidgets/CMakeLists.txt 3dd1fe3 > staging/kwidgets/KWidgetsConfig.cmake.in PRE-CREATION > staging/kwidgets/kwidgetsConfig.cmake.in bf761ac > staging/kwidgets/src/CMakeLists.txt 9ae3c2e > > Diff: http://git.reviewboard.kde.org/r/111493/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Port > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
