----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111080/#review36321 -----------------------------------------------------------
Ship it! Looks good. If it builds for you, go ahead. :-) - Alexander Neundorf On July 22, 2013, 7:10 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111080/ > ----------------------------------------------------------- > > (Updated July 22, 2013, 7:10 p.m.) > > > Review request for KDE Frameworks and Alexander Neundorf. > > > Description > ------- > > MacroAddCompileFlags.cmake > MacroAddLinkFlags.cmake > MacroAdditionalCleanFiles.cmake > MacroEnsureVersion.cmake > MacroLogFeature.cmake > MacroOptionalAddSubdirectory.cmake > MacroOptionalDependPackage.cmake > MacroOptionalFindPackage.cmake > MacroPushRequiredVars.cmake > MacroWriteBasicCMakeVersionFile.cmake > > have been removed. > > > Diffs > ----- > > CMakeLists.txt c6698d2 > cmake/modules/CMakeLists.txt 5f89640 > cmake/modules/KDE4Macros.cmake aad07b6 > cmake/modules/MacroAddCompileFlags.cmake 12038c0 > cmake/modules/MacroAddLinkFlags.cmake a10d39e > cmake/modules/MacroAdditionalCleanFiles.cmake 593182f > cmake/modules/MacroEnsureVersion.cmake 6797e5b > cmake/modules/MacroLibrary.cmake 6255f6f > cmake/modules/MacroLogFeature.cmake 631c7ac > cmake/modules/MacroOptionalAddSubdirectory.cmake ec0ea30 > cmake/modules/MacroOptionalDependPackage.cmake 2ea7996 > cmake/modules/MacroOptionalFindPackage.cmake d4ed48e > cmake/modules/MacroPushRequiredVars.cmake 650b566 > cmake/modules/MacroWriteBasicCMakeVersionFile.cmake 6f9e418 > experimental/CMakeLists.txt 50efe96 > kdecore/localization/ConfigureChecks.cmake bccc1d1 > kdeui/CMakeLists.txt d317598 > khtml/java/CMakeLists.txt 51f3041 > kio/CMakeLists.txt 12569d5 > kio/kio/thumbcreator.h 6cf19d6 > kioslave/file/CMakeLists.txt 8461b71 > staging/kio/src/core/ConfigureChecks.cmake e88debf > staging/knotifications/src/CMakeLists.txt 33aa9df > > Diff: http://git.reviewboard.kde.org/r/111080/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel