----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review37059 -----------------------------------------------------------
Ship it! staging/kservice/src/services/kplugininfo.cpp <http://git.reviewboard.kde.org/r/111688/#comment27390> this if() can be removed, actually, given the next one. - David Faure On July 30, 2013, 2:41 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111688/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 2:41 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > This patch allows KPluginInfo to be created from a QVariantList, as it is > typically passed in from KPluginFactory (using the patch which changes the > macro there). > > > Diffs > ----- > > staging/kservice/src/services/kplugininfo.h c000008 > staging/kservice/src/services/kplugininfo.cpp bd1eaec > staging/kservice/src/services/kservice.h a116e22 > > Diff: http://git.reviewboard.kde.org/r/111688/diff/ > > > Testing > ------- > > Works with plugins built in the right way: A valid KPluginInfo is created > from the plugin's metadata. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
