----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/ -----------------------------------------------------------
(Updated Aug. 5, 2013, 10:59 p.m.) Review request for KDE Frameworks and David Faure. Changes ------- Right, I confused two macros, when I removed that build warning hack, have put it back in. Other comments have been addressed as well. Description ------- Make K_EXPORT_PLUGIN work with Qt's new plugin system This patch changes the K_EXPORT_MACRO and the class it generates to be compatible with Qt's new plugin / metadata system. It basically replaces the old macros around q_plugin_instance with the new ones, using Q_INTERFACES. There's also a setter for the args, which are used to pass metadata into the plugin. Otherwise, this is the minimal change, to make old plugin factories work atop the new framework. This change is source-compatible, but the right .moc file when this macro is used from the .cpp file. Diffs (updated) ----- staging/kservice/src/plugin/kexportplugin.h cc5d58b staging/kservice/src/plugin/kpluginfactory.h a5ea21b Diff: http://git.reviewboard.kde.org/r/111686/diff/ Testing ------- Loaded plugins using KService, KPluginLoader, QPluginLoader and Plasma::PluginLoader, all work as expected. Thanks, Sebastian Kügler
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
