----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37335 -----------------------------------------------------------
You're moving kfilemetainfo but not predicateproperties? Isn't predicateproperties used by kfilemetainfo? Same problem with KFileMetaInfoItem and KFileWritePlugin. - Vishesh Handa On Aug. 7, 2013, 4:23 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111897/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2013, 4:23 p.m.) > > > Review request for KDE Frameworks and Vishesh Handa. > > > Description > ------- > > As far as I've understood, we should have an alternative by Nepomuk for file > previewing for KF5, this patch moves the KFileMetaInfo and the files that > depend on it to KDE4Support. > > It's worth noting that there are 2 "plugins" (they're actually not plugins) > of the KPropertiesDialog that have been disabled because they had to be moved > with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp > > > Diffs > ----- > > staging/kde4support/autotests/kiotesthelper.h PRE-CREATION > staging/kde4support/autotests/CMakeLists.txt 22da9ae > kioslave/metainfo/metainfo.protocol > kioslave/metainfo/metainfo.cpp > kioslave/metainfo/metainfo.h > kioslave/metainfo/CMakeLists.txt a448576 > kioslave/CMakeLists.txt c16b33e > kio/tests/kmfitest.cpp > kio/tests/kfilemetainfotest.cpp 74d518b > kio/tests/kfilemetainfotest.h > kio/tests/CMakeLists.txt 6e8c6e7 > kio/kio/kfilemetainfoitem_p.h 607ac3e > kio/kio/kfilemetainfoitem.cpp fbaefe0 > kio/kio/kfilemetainfoitem.h b414274 > kio/kio/kfilemetainfo.cpp a87a8a0 > kio/kio/kfilemetainfo.h ddd26d3 > kio/kfile/kpropertiesdialog.cpp 687e4bf > kio/kfile/kpreviewprops.cpp > kio/kfile/kpreviewprops.h 8a974da > kio/kfile/knfotranslator_p.h > kio/kfile/knfotranslator.cpp 64bcecc > kio/kfile/kmetaprops.cpp > kio/kfile/kmetaprops.h a08c380 > kio/kfile/kfilemetadatawidget.cpp 6e0f106 > kio/kfile/kfilemetadatawidget.h 2dc4677 > kio/kfile/kfilemetadatareaderprocess.cpp > kio/kfile/kfilemetadatareader_p.h > kio/kfile/kfilemetadatareader.cpp > kio/kfile/kfilemetadataprovider_p.h 8009bf4 > kio/kfile/kfilemetadataprovider.cpp > kio/kfile/kfilemetadataconfigurationwidget.cpp 5fbf8dc > kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d > kio/kfile/kcommentwidget_p.h > kio/kfile/kcommentwidget.cpp f125bc7 > kio/CMakeLists.txt 0e6c50d > staging/kde4support/src/CMakeLists.txt 4ea3497 > staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 > staging/kde4support/src/kioslave/CMakeLists.txt PRE-CREATION > staging/kde4support/src/kioslave/metainfo/CMakeLists.txt PRE-CREATION > staging/kde4support/tests/CMakeLists.txt 41e35ce > > Diff: http://git.reviewboard.kde.org/r/111897/diff/ > > > Testing > ------- > > builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte > status? > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel