----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/#review39047 -----------------------------------------------------------
Ship it! Testing that it compiles isn't enough, please test that the unittests still pass. :) Too bad I can't find a test for this precise feature, but at least it would be good to check that nothing regresses. tier1/kcoreaddons/src/lib/jobs/kjob_p.h <http://git.reviewboard.kde.org/r/112407/#comment28791> To the casual reader, this member var appears to be unused and therefore useless. Could you move the old comment here? "Don't exit while the job is running" or something like that. - David Faure On Aug. 31, 2013, 4:29 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112407/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2013, 4:29 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Port KJob to QEventLoopLocker > > > Diffs > ----- > > tier1/kcoreaddons/src/lib/jobs/kjob.cpp d31c80b > tier1/kcoreaddons/src/lib/jobs/kjob_p.h 6618fc4 > > Diff: http://git.reviewboard.kde.org/r/112407/diff/ > > > Testing > ------- > > It compiles > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
