> On Sept. 3, 2013, 12:34 p.m., David Faure wrote: > > staging/kbookmarks/tests/CMakeLists.txt, line 9 > > <http://git.reviewboard.kde.org/r/112479/diff/1/?file=186788#file186788line9> > > > > Isn't that only for unittests? > > David Edmundson wrote: > If this is wrong kconfigwidgets and ktextwidgets and kcompletion are also > wrong. > > I've pushed as-is for now, if this is wrong, let me know and I'll check > all the modules.
Ah, I confused add_test and ecm_mark_as_test. The word "test" means something different in these two things. add_test == run this autotest when typing "make test" ecm_mark_as_test == don't compile this program if BUILD_TESTING is false. This can indeed be applied to manual test programs too. So you did the right thing :) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/#review39255 ----------------------------------------------------------- On Sept. 4, 2013, 4:59 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112479/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2013, 4:59 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Split Bookmarks out of kio folder into own folder in staging. > > This is simply a splitting + moving + removing deprecated functions, I am > aware it doesn't comply with a lot of other things on the frameworks > checklist yet. > > It is possible to split kbookmarks into core + gui. Do we want that? > > We also need to decide what tier this is aiming for. I think 3 as we use > parts of KIO. > > > Diffs > ----- > > kio/CMakeLists.txt 167f697 > kio/bookmarks/kbookmark.h 2d06120 > kio/bookmarks/kbookmark.cc beb82db > kio/bookmarks/kbookmarkdialog.h > kio/bookmarks/kbookmarkdialog.cc > kio/bookmarks/kbookmarkdialog_p.h > kio/bookmarks/kbookmarkdombuilder.h > kio/bookmarks/kbookmarkdombuilder.cc > kio/bookmarks/kbookmarkexporter.h > kio/bookmarks/kbookmarkimporter.h > kio/bookmarks/kbookmarkimporter.cc > kio/bookmarks/kbookmarkimporter_ie.h > kio/bookmarks/kbookmarkimporter_ie.cc > kio/bookmarks/kbookmarkimporter_ns.h > kio/bookmarks/kbookmarkimporter_ns.cc > kio/bookmarks/kbookmarkimporter_opera.h > kio/bookmarks/kbookmarkimporter_opera.cc > kio/bookmarks/kbookmarkimporter_opera_p.h > kio/bookmarks/kbookmarkmanager.h > kio/bookmarks/kbookmarkmanager.cc > kio/bookmarks/kbookmarkmanageradaptor.cc > kio/bookmarks/kbookmarkmanageradaptor_p.h > kio/bookmarks/kbookmarkmenu.h > kio/bookmarks/kbookmarkmenu.cc > kio/bookmarks/kbookmarkmenu_p.h > kio/bookmarks/konqbookmarkmenu.h > kio/bookmarks/konqbookmarkmenu.cc > kio/tests/CMakeLists.txt e9e7265 > kio/tests/kbookmarkdialogtest.cpp > kio/tests/kbookmarktest.h > kio/tests/kbookmarktest.cpp > staging/CMakeLists.txt 1602d95 > staging/kbookmarks/CMakeLists.txt PRE-CREATION > staging/kbookmarks/autotests/CMakeLists.txt PRE-CREATION > staging/kbookmarks/src/CMakeLists.txt PRE-CREATION > staging/kbookmarks/tests/CMakeLists.txt PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112479/diff/ > > > Testing > ------- > > compiles + test runs. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel