----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/#review39569 -----------------------------------------------------------
Anything that had "TEST" should now have ecm_mark_as_test. You missed a few towards the end. BTW is there a porting guide for kde4_add_executable -> add_executable? People porting the other modules will have the same issue. experimental/kdeclarative/CMakeLists.txt <http://git.reviewboard.kde.org/r/112570/#comment29150> This looks like a manual GUI test program, not like a unittest. Try "make test" in this dir, to see the problem :) -> remove the add_test line. (TODO for another patch: rename the subdir to tests and move this into its own CMakeLists.txt) kinit/CMakeLists.txt <http://git.reviewboard.kde.org/r/112570/#comment29151> move this line out of the if (APPLE), now that it's the same on all platforms. kinit/CMakeLists.txt <http://git.reviewboard.kde.org/r/112570/#comment29152> This could also be moved out of the if, by using the proper arguments for ecm_mark_nongui_executable, so that it doesn't disable the mac bundle. kinit/CMakeLists.txt <http://git.reviewboard.kde.org/r/112570/#comment29153> why didn't this one get ecm_mark_nongui_executable? kio/tests/CMakeLists.txt <http://git.reviewboard.kde.org/r/112570/#comment29155> you'll replace all kde4_add_unit_test in another patch? ;) kio/tests/CMakeLists.txt <http://git.reviewboard.kde.org/r/112570/#comment29154> missing ecm_mark_as_test kioslave/http/kcookiejar/CMakeLists.txt <http://git.reviewboard.kde.org/r/112570/#comment29156> This looks wrong to me. All the lines above add stuff to kcookiejar_SRCS. You should keep using that instead of just main.cpp. I'm surprised this actually compiled... - David Faure On Sept. 6, 2013, 6:52 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112570/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 6:52 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > kde4_add_executable is deprecated. Port all kde4_add_executable uses to > add_executable. > > > Diffs > ----- > > experimental/kdeclarative/CMakeLists.txt a7bddfa > interfaces/terminal/example/CMakeLists.txt e8c3f01 > kdesu/CMakeLists.txt 351ad85 > kdewidgets/CMakeLists.txt 038da6b > khtml/CMakeLists.txt 124c3eb > kinit/CMakeLists.txt ff7b7fd > kio/misc/CMakeLists.txt e2c62d6 > kio/misc/kpac/CMakeLists.txt 04ffba1 > kio/misc/ksendbugmail/CMakeLists.txt cbe4bd9 > kio/tests/CMakeLists.txt 825ca3c > kioslave/http/kcookiejar/CMakeLists.txt fcb620e > kjsembed/examples/kjsconsole/CMakeLists.txt 2438323 > kjsembed/kjscmd/CMakeLists.txt f457933 > knotify/tests/CMakeLists.txt bc6f5e0 > kparts/tests/CMakeLists.txt bb8a120 > kpty/CMakeLists.txt 2cc2885 > kross/console/CMakeLists.txt 58257ca > staging/kde4support/CMakeLists.txt 0445f0a > staging/kde4support/src/CMakeLists.txt 6f4603d > staging/kemoticons/tests/CMakeLists.txt 5e0d46e > > Diff: http://git.reviewboard.kde.org/r/112570/diff/ > > > Testing > ------- > > Builds, although it doesn't change much in linux. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel