----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112574/#review39572 -----------------------------------------------------------
Ship it! knewstuff/knewstuff3/ui/entrydetailsdialog.h <http://git.reviewboard.kde.org/r/112574/#comment29157> entrydetailsdialog.h is not installed, right? So this is fine. But it should be named entrydetailsdialog_p.h to avoid confusion. Any private header should be _p.h. (this is for a separate commit though) - David Faure On Sept. 7, 2013, 4:08 a.m., Jeremy Paul Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112574/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2013, 4:08 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > I renamed knewstuff/knewstuff3 to knewstuff/src and rearranged the TODO files > a bit. > Also fixed build issues with code that was #including <knewstuff3/*> when it > shouldn't have been. > > > Diffs > ----- > > knewstuff/knewstuff3/TODO d8905f53ad526350c4a5f89d713f06388cdeb56d > knewstuff/knewstuff3/CMakeLists.txt > knewstuff/TODO.knewstuff2 PRE-CREATION > knewstuff/TODO 6bd4dc4f263badf2e9a2e75b5becacd3d48d4e52 > knewstuff/CMakeLists.txt a402e82096d25c3b75182202fbb6594c3d22a02f > knewstuff/knewstuff3/attica/atticaprovider.h > knewstuff/knewstuff3/attica/atticaprovider.cpp > knewstuff/knewstuff3/core/CLASSES > knewstuff/knewstuff3/core/DESIGN > knewstuff/knewstuff3/core/USE-CASES > knewstuff/knewstuff3/core/author.h > knewstuff/knewstuff3/core/author.cpp > knewstuff/knewstuff3/core/cache.h > knewstuff/knewstuff3/core/cache.cpp > knewstuff/knewstuff3/core/engine.h > knewstuff/knewstuff3/core/engine.cpp > knewstuff/knewstuff3/core/entryinternal.h > ea88cad9d3d4626e6845f96ca5054b6a9f1f761a > knewstuff/knewstuff3/core/entryinternal.cpp > 08f2611950f0faf805e1dd84200fa56ac20c3f7e > knewstuff/knewstuff3/core/installation.h > knewstuff/knewstuff3/core/installation.cpp > knewstuff/knewstuff3/core/provider.h > knewstuff/knewstuff3/core/provider.cpp > knewstuff/knewstuff3/core/security.h > knewstuff/knewstuff3/core/security.cpp > knewstuff/knewstuff3/core/upload.h > knewstuff/knewstuff3/core/upload.cpp > knewstuff/knewstuff3/core/xmlloader.h > knewstuff/knewstuff3/core/xmlloader.cpp > knewstuff/knewstuff3/downloaddialog.h > knewstuff/knewstuff3/downloaddialog.cpp > knewstuff/knewstuff3/downloadmanager.h > knewstuff/knewstuff3/downloadmanager.cpp > knewstuff/knewstuff3/downloadwidget.h > knewstuff/knewstuff3/downloadwidget.cpp > knewstuff/knewstuff3/downloadwidget.ui > knewstuff/knewstuff3/downloadwidget_p.h > knewstuff/knewstuff3/entry.h > knewstuff/knewstuff3/entry.cpp 991a3826255b3b6dd45923c3cca5ad4512ed4787 > knewstuff/knewstuff3/entry_p.h > knewstuff/knewstuff3/knewstuffaction.h > knewstuff/knewstuff3/knewstuffaction.cpp > knewstuff/knewstuff3/knewstuffbutton.h > knewstuff/knewstuff3/knewstuffbutton.cpp > knewstuff/knewstuff3/staticxml/staticxmlprovider.h > knewstuff/knewstuff3/staticxml/staticxmlprovider.cpp > knewstuff/knewstuff3/ui/entrydetailsdialog.h > 52733d78f1b727b718bfa3dd9925f7f46d73528a > knewstuff/knewstuff3/ui/entrydetailsdialog.cpp > 8d3441f2ad6096df1312a516e29cb17b89d8e024 > knewstuff/knewstuff3/ui/imageloader.h > knewstuff/knewstuff3/ui/imageloader.cpp > knewstuff/knewstuff3/ui/imagepreviewwidget.h > knewstuff/knewstuff3/ui/imagepreviewwidget.cpp > knewstuff/knewstuff3/ui/itemsgridviewdelegate.h > knewstuff/knewstuff3/ui/itemsgridviewdelegate.cpp > knewstuff/knewstuff3/ui/itemsmodel.h > knewstuff/knewstuff3/ui/itemsmodel.cpp > knewstuff/knewstuff3/ui/itemsview.h > knewstuff/knewstuff3/ui/itemsview.cpp > knewstuff/knewstuff3/ui/itemsviewbasedelegate.h > knewstuff/knewstuff3/ui/itemsviewbasedelegate.cpp > knewstuff/knewstuff3/ui/itemsviewdelegate.h > knewstuff/knewstuff3/ui/itemsviewdelegate.cpp > knewstuff/knewstuff3/ui/progressindicator.h > knewstuff/knewstuff3/ui/progressindicator.cpp > knewstuff/knewstuff3/upload/atticahelper.h > knewstuff/knewstuff3/upload/atticahelper.cpp > knewstuff/knewstuff3/uploaddialog.h > knewstuff/knewstuff3/uploaddialog.cpp > knewstuff/knewstuff3/uploaddialog.ui > knewstuff/knewstuff3/uploaddialog_p.h > > Diff: http://git.reviewboard.kde.org/r/112574/diff/ > > > Testing > ------- > > It builds and installs. > > > Thanks, > > Jeremy Paul Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel