----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112716/#review40014 -----------------------------------------------------------
Ship it! Looks ok to me (but if we're soon dropping the kcoreaddons dep then maybe this can be rebased on top of that, to avoid going back and forth about the kcoreaddons dep?). If it fixes a more short-term compilation issue, ship it. - David Faure On Sept. 13, 2013, 3:09 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112716/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 3:09 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > - Use REQUIRED_QT_VERSION in CMakeLists and ItemViewsConfig.cmake.in > - Add dependency on KCoreAddons (which will go away when we can use QCollator) > > This review replace my previous version, which also moved the itemviews/ dir > to tier2. This is not good because if/when we can use QCollator the > dependency on KCoreAddons can be dropped and ItemViews can be a tier1 > framework. > > > Diffs > ----- > > staging/itemviews/CMakeLists.txt f5c3c8d > staging/itemviews/ItemViewsConfig.cmake.in c10f49f > > Diff: http://git.reviewboard.kde.org/r/112716/diff/ > > > Testing > ------- > > Builds within kdelibs and standalone. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
