----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41217 -----------------------------------------------------------
kpty/CMakeLists.txt <http://git.reviewboard.kde.org/r/113088/#comment30238> You're missing KCoreAddons here. Though I'm not sure if you need to care about it now since we don't care about individual builds of tiers >1 yet... kpty/KPtyConfig.cmake.in <http://git.reviewboard.kde.org/r/113088/#comment30237> You probably don't need this as you don't link to it in LINK_PUBLIC. Actually is there any actual usage of i18n? This was in kdesu as well but no i18n was used. - Martin Klapetek On Oct. 4, 2013, 11:52 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113088/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 11:52 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Prepare kpty for moving > > > Diffs > ----- > > kpty/tests/CMakeLists.txt 1f39830 > kpty/src/CMakeLists.txt PRE-CREATION > kpty/kptyprocess.cpp > kpty/kptyprocess.h > kpty/kptydevice.h > kpty/kptydevice.cpp > kpty/kpty_p.h > kpty/kpty.cpp > kpty/kgrantpty.c > kpty/kpty.h > kpty/config-pty.h.cmake > kpty/KPtyConfig.cmake.in PRE-CREATION > kpty/ConfigureChecks.cmake > kpty/CMakeLists.txt ecc296c > > Diff: http://git.reviewboard.kde.org/r/113088/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel