> On Oct. 7, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote: > > kded/kbuildsycoca.cpp, line 48 > > <http://git.reviewboard.kde.org/r/113148/diff/1/?file=199659#file199659line48> > > > > What happens with this? > > Àlex Fiestas wrote: > I vote for removing it, any objections ?
Plus I forgot to move some code that sets this in case "KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION" is set. Will wait until David comment on this to either move it or simply remove it. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/#review41351 ----------------------------------------------------------- On Oct. 7, 2013, 3:21 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113148/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2013, 3:21 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Moved KBuildsyscoca to KService. > > I have done the moving and the cleaning in different commits, just unified > them for reviewboard. > > > Diffs > ----- > > kded/CMakeLists.txt 4f9133f > kded/applications.menu > kded/kbuildmimetypefactory.h > kded/kbuildmimetypefactory.cpp 2e81ce7 > kded/kbuildservicefactory.h > kded/kbuildservicefactory.cpp 971f327 > kded/kbuildservicegroupfactory.h > kded/kbuildservicegroupfactory.cpp 5485b1c > kded/kbuildservicetypefactory.h > kded/kbuildservicetypefactory.cpp f473cd6 > kded/kbuildsycoca.h > kded/kbuildsycoca.cpp 8ea2d2e > kded/kbuildsycocainterface.h > kded/kctimefactory.h > kded/kctimefactory.cpp > kded/kmimeassociations.h > kded/kmimeassociations.cpp > kded/ksycocaresourcelist.h > kded/tests/CMakeLists.txt ca392d2 > kded/tests/kmimeassociationstest.cpp > kded/vfolder_menu.h > kded/vfolder_menu.cpp > staging/kservice/CMakeLists.txt b244731 > staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION > staging/kservice/tests/CMakeLists.txt 23d4854 > > Diff: http://git.reviewboard.kde.org/r/113148/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel