----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113076/#review41389 -----------------------------------------------------------
This review has been submitted with commit 8dda23a557ead9013e177467256f6c7f18d915b8 by Aurélien Gâteau to branch frameworks. - Commit Hook On Oct. 7, 2013, 12:47 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113076/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2013, 12:47 p.m.) > > > Review request for KDE Frameworks and John Layt. > > > Repository: kdelibs > > > Description > ------- > > This fixes kcookiejartest, which was failing to parse the date from the Y2K38 > check. > > The test started failing on build.kde.org when the Qt version here was > switched to the "stable" branch, which seems to parse things differently than > the version of Qt build.kde.org used to run. > > The code was ported from KDateTime::fromString() to QDateTime::fromString(), > whose syntax for date formatting is different, but the format was not updated. > > This patch is incomplete, see the FIXME comments in removeTimeZone(). But I > want to ensure this is the correct way to go before getting into timezones. > > > Diffs > ----- > > kioslave/http/kcookiejar/kcookiejar.cpp e943da9 > > Diff: http://git.reviewboard.kde.org/r/113076/diff/ > > > Testing > ------- > > kcookiejartest now passes again (must be run with LANG=C btw) > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
