----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/#review41441 -----------------------------------------------------------
Ship it! OK, that's a small SIC... but OK, we don't have that many users of that class anyway and it's easy to port. - Kevin Ottens On Sept. 24, 2013, 2:33 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112918/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2013, 2:33 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Add index argument to KWidgetItemDelegate::createItemWidgets > > This fixes a KDE5 TODO which used to pass an argument as a property > > > Diffs > ----- > > staging/kcmutils/src/kpluginselector.cpp > 77cbfda5987195f15341e41c3280726e5583d87e > KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d > staging/kcmutils/src/kpluginselector_p.h > 2dffae05dd87cc299ecdb05612f02dd2ad37cd2c > staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h > 0e325915070006d2cfa093719d5c967f3181737d > staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp > 84f9ca548068088c0bc0ff99fa460e5f7fecbccd > tier1/itemviews/src/kwidgetitemdelegate.h > b874c10e9a7ab9ee9bf756ae82ce99bd64ec92d1 > tier1/itemviews/src/kwidgetitemdelegatepool.cpp > e9bbcad0b030c8d03fadeb6635bfa0d69d996ac9 > tier1/itemviews/tests/kwidgetitemdelegatetest.cpp > cfca1f9ae3df9bec1e8a570f03b5256cc935e8bb > > Diff: http://git.reviewboard.kde.org/r/112918/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
