----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/#review41570 -----------------------------------------------------------
tier1/kcoreaddons/src/lib/jobs/kjob.h <http://git.reviewboard.kde.org/r/113205/#comment30378> You are kind of now actually making it fully public so that it can be emitted by others, contrary to what the documentation seems to imply. I think QAIM had a similar thing that steve solved with a bit of magic. We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. - Sune Vuorela On Oct. 11, 2013, 5:59 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113205/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 5:59 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > The new signal/slot connection: > connect(job, &KJob::result,... > > does't like result to be private and throws an compile error: > error: 'void KJob::result(KJob*)' is private > > Making it public resolves the issue and makes this slot usable in the new > syntax. In my case i wanted to use the new syntax and directly use a lambda > as slot. Which isn't possible on this signal if it isn't public. > > > Diffs > ----- > > tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 > > Diff: http://git.reviewboard.kde.org/r/113205/diff/ > > > Testing > ------- > > Works just fine. > > > Thanks, > > Mark Gaiser > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel