----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113238/#review41699 -----------------------------------------------------------
Ship it! Also consider (separately) removing the _LIBRARIES variables from the Config files, so that there is one consistent way to use a KF5 framework (KF5::Solid, not Solid_LIBRARIES). kde-workspace and plasma currently mix both and should be normalized first, obviously. - Stephen Kelly On Oct. 14, 2013, 10:43 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113238/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 10:43 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Remove set _LIBRARIES calls in root CMakeLists.txt > > Update all other modules to use KF5::LibraryName > > > Diffs > ----- > > CMakeLists.txt 17c3090 > kded/CMakeLists.txt 7532687 > kdewidgets/CMakeLists.txt 885091e > khtml/src/CMakeLists.txt 5e00c8c > khtml/src/kmultipart/CMakeLists.txt 3fc6982 > kio/misc/kpac/CMakeLists.txt 897de8e > staging/kio/src/core/CMakeLists.txt 5d75fc9 > staging/kio/src/filewidgets/CMakeLists.txt 3790250 > > Diff: http://git.reviewboard.kde.org/r/113238/diff/ > > > Testing > ------- > > compiled > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel