> On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote: > > -1 > > > > I disagree with the removal, OK they get deprecated in KDE4... but it's > > been done only recently (the patch isn't even in yet). We still have a > > couple of users for those classes and it would be one more breakage on our > > SC promise (and one we can avoid at that). > > Kevin Ottens wrote: > Of course I meant for the removals in kde4support. The comments cleanup > in kio I'm fine with it. > > Vishesh Handa wrote: > Well, avoiding that would be mean that I need to either (1) port it to > Nepomuk2 and thus get a dependency to nepomuk-core or (2) remove all the > Nepomuk code. If it is really required I can go with (2), though it'll be a > lot more work. > > The nepomuk-core replacement classes are almost source compatible with > the kio ones. So the port is mostly just changing the class name, and linking > to the new library. Also, Konversation and Conquire (Nepomuk app) seems to be > the only users of this class. KGet has been ported. > > Do you still want me to go with (2)? > > Kevin Ottens wrote: > OK, I guess I miss a piece of information then: What happened to the > Nepomuk API it currently uses? Did it simply disappear? if yes it means even > more broken promises. :-) > > Vishesh Handa wrote: > The Nepomuk API that was originally in kdelibs/nepomuk was removed very > long ago. The code now lives in nepomuk-core and nepomuk-widgets. We almost > maintain source compatibility (minus some small things).
OK, so that's what I had in mind. It means the API used by those classes in kde4support you're trying to remove is still there for their consumption, so why not just let them alone? I don't see the benefit of removing them or porting them to something different, it'll just create more build errors to code built against kf5, making ports harder. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/#review41676 ----------------------------------------------------------- On Oct. 10, 2013, 12:56 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113154/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2013, 12:56 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Remove KFileMetaDataWidget and friends > > These have been deprecated in KDE4.[1] This also removes the > KFileMetaPropsPlugin in the KPropertiesDialog - The code was commented > out so it doesn't really make a difference. > > Eventually we will need a proper plugin based system so that the > Nepomuk2::FileMetadataWidget can be used in the KPropertiesDialog > > [1] https://git.reviewboard.kde.org/r/113153/ > > > Diffs > ----- > > KDE5PORTING.html 3171afc > kdewidgets/kde.widgets b138d4e > staging/kde4support/src/CMakeLists.txt 5eb649c > staging/kde4support/src/kio/kcommentwidget.cpp 6223a0c > staging/kde4support/src/kio/kcommentwidget_p.h 7a9c710 > staging/kde4support/src/kio/kfilemetadataconfigurationwidget.h 52735ad > staging/kde4support/src/kio/kfilemetadataconfigurationwidget.cpp 018d183 > staging/kde4support/src/kio/kfilemetadataprovider.cpp 59cb238 > staging/kde4support/src/kio/kfilemetadataprovider_p.h 0969f53 > staging/kde4support/src/kio/kfilemetadatareader.cpp 6a7909c > staging/kde4support/src/kio/kfilemetadatareader_p.h af054c2 > staging/kde4support/src/kio/kfilemetadatareaderprocess.cpp 0d2b993 > staging/kde4support/src/kio/kfilemetadatawidget.h 31dd3c7 > staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df2312 > staging/kde4support/src/kio/kmetaprops.h b03dd4c > staging/kde4support/src/kio/kmetaprops.cpp 46624c5 > staging/kde4support/src/kio/knfotranslator.cpp 0494679 > staging/kde4support/src/kio/knfotranslator_p.h ddbe4a1 > staging/kio/src/widgets/kpropertiesdialog.cpp 63e4435 > > Diff: http://git.reviewboard.kde.org/r/113154/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
