> On Oct. 15, 2013, 1:44 p.m., Kevin Ottens wrote: > > staging/knotifyconfig/CMakeLists.txt, line 17 > > <http://git.reviewboard.kde.org/r/113248/diff/1/?file=201274#file201274line17> > > > > Shouldn't this type of conditional removed now that we use alias > > targets? Or you plan to change that in another commit?
No, that should stay as long as it can be compiled from a higher module. Otherwise all modules would be writing their own summary. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41776 ----------------------------------------------------------- On Oct. 14, 2013, 5:33 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113248/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 5:33 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Sort dependencies out, adopt the different cmake constructions to make sure > everything will be installed properly. > > > Diffs > ----- > > staging/knotifyconfig/CMakeLists.txt 65867ba > staging/knotifyconfig/KNotifyConfigConfig.cmake.in fbdea78 > staging/knotifyconfig/src/CMakeLists.txt 9be9ba4 > staging/knotifyconfig/tests/CMakeLists.txt 1ed0360 > > Diff: http://git.reviewboard.kde.org/r/113248/diff/ > > > Testing > ------- > > builds, teh test seems to work still. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel