----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/#review41850 -----------------------------------------------------------
Ship it! tier1/kidletime/CMakeLists.txt <http://git.reviewboard.kde.org/r/113276/#comment30542> really needed? Good work! :) - Aleix Pol Gonzalez On Oct. 16, 2013, 4:44 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113276/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2013, 4:44 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kdelibs > > > Description > ------- > > Calls to functions provided by includes must come after includes themselves. > > This request also includes a separate commit for template/CMakeLists.txt, > which moves all calls to find_package() after ecm is setup and provide a hint > as to where find_package() calls should be. This should hopefully help > prevent future errors. > > > Diffs > ----- > > template/CMakeLists.txt 96a5363 > tier1/kidletime/CMakeLists.txt 21e9f37 > tier1/kjs/CMakeLists.txt 9c2acaa > tier1/kwindowsystem/CMakeLists.txt e4f984b > > Diff: http://git.reviewboard.kde.org/r/113276/diff/ > > > Testing > ------- > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel