> On Oct. 21, 2013, 1:43 p.m., Kevin Ottens wrote: > > tier2/kdoctools/CMakeLists.txt, line 18 > > <http://git.reviewboard.kde.org/r/113328/diff/2/?file=203416#file203416line18> > > > > FOOBAR really? :-) > > > > In fact ecm_setup_version might not even be needed for that one, it has > > no lib, just a runtime tool IIRC.
Oups, copy'n'paste from template is dangerous :) Anyway you are right, ecm_setup_version() is not needed here, just updated the request. - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42080 ----------------------------------------------------------- On Oct. 21, 2013, 3:32 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113328/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 3:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Fix standalone build of kdoctools: it was not looking for KArchive. This > patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. > > > Diffs > ----- > > superbuild/CMakeLists.txt 5cdec94 > tier2/kdoctools/CMakeLists.txt 53fd0e9 > tier2/kdoctools/src/CMakeLists.txt 8b726a8 > > Diff: http://git.reviewboard.kde.org/r/113328/diff/ > > > Testing > ------- > > Builds within kdelibs and using superbuild. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel