On Mon, Oct 21, 2013 at 2:54 PM, Stephen Kelly <steve...@gmail.com> wrote:
> Git commit 5e9404239fb974973e8a253444131884954ede77 by Stephen Kelly. > Committed on 21/10/2013 at 12:49. > Pushed by skelly into branch 'frameworks'. > > Add include/KDE to users of KIOCore. > > Note that this really only hides the problem. There are several problems > with the KF5 includes, and several patches in review which also don't > fully solve the problem. > > What is needed is to figure out > > * Where are headers installed to? > * How are users supposed to use them? > * What include paths do users need to use? > > For example, if kfoo installs > > include/kfoo/job.h > include/kfoo/kfoo_export.h > > and users are supposed to use: > > .#include <kfoo/job.h> > > but job.h #includes <kfoo_export.h> > > then users need both > > include/ > include/kfoo/ > > when compiling. That seems to be the case at some points in KDE > frameworks, and it is more-likely accidental than intentional. > > That should be reviewed. > > CCMAIL: kde-frameworks-devel@kde.org > > M +1 -0 staging/kio/src/core/CMakeLists.txt > > http://commits.kde.org/kdelibs/5e9404239fb974973e8a253444131884954ede77 > > diff --git a/staging/kio/src/core/CMakeLists.txt > b/staging/kio/src/core/CMakeLists.txt > index 273086f..03a892b 100644 > --- a/staging/kio/src/core/CMakeLists.txt > +++ b/staging/kio/src/core/CMakeLists.txt > @@ -108,6 +108,7 @@ target_include_directories(KIOCore PUBLIC > "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/..>" # kio_version.h > "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/kssl>" > "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../include>" # > kio/global.h > + "$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/KDE>" # KIO/Job > ) > > target_link_libraries(KIOCore > _______________________________________________ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > FWIW, KDE/ should be added to most modules then... Aleix
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel