-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113297/#review42139
-----------------------------------------------------------


This review has been submitted with commit 
f86c5a9f96b571c15f1b529f9e497022da59c567 by Nicolás Alvarez to branch 
frameworks.

- Commit Hook


On Oct. 17, 2013, 12:08 a.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113297/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 12:08 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Remove 'override' from ThreadWeaver::IdDecorator destructor.
> 
> MSVC2010 apparently doesn't support 'override' on destructors,
> even though it's legal according to C++11.
> 
> 
> Diffs
> -----
> 
>   tier1/threadweaver/src/Weaver/IdDecorator.h 
> 648d4236cc22015a1d145892daf368084a199053 
> 
> Diff: http://git.reviewboard.kde.org/r/113297/diff/
> 
> 
> Testing
> -------
> 
> Still builds on Linux, now builds on Windows too.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to