> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 29 > > <http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29> > > > > This variable shouldn't be needed at all. > > Aleix Pol Gonzalez wrote: > Variable? Or argument? Why? > > Stephen Kelly wrote: > Argument, yes, sorry. > > I think that because the source dir is already in the > INTERFACE_INCLUDE_DIRECTORIES of the target, there is no need to have to > specify it, and there should be no need to use ${EGH_HEADERS_DIR}/ in the > generated include. > > I guess you have some reason for doing that, but that just points to > non-uniformity which should maybe be fixed, as I wrote in the KIO commit I > linked to. > > Alexander Neundorf wrote: > I don't see any target involved here...
So maybe we should link the generated headers to a target? - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 ----------------------------------------------------------- On Oct. 24, 2013, 1:40 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113406/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 1:40 p.m.) > > > Review request for Build System, KDE Frameworks and Stephen Kelly. > > > Repository: extra-cmake-modules > > > Description > ------- > > Create a macro that will generate the forward headers like we used to, in > cmake configure time. > > Here's an example of how we'd port KParts to that macro: > http://paste.opensuse.org/9880051 > After the change, these are the installed headers: > http://paste.opensuse.org/90980400 > > > Diffs > ----- > > modules/ECMGenerateHeaders.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113406/diff/ > > > Testing > ------- > > Ported KParts and still everything works. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
