----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113422/#review42416 -----------------------------------------------------------
Ship it! Just one comment to fix first. tier1/kconfig/autotests/kconfignokdehometest.cpp <http://git.reviewboard.kde.org/r/113422/#comment30806> Aleix: this line makes QStandardPaths point to a test directory. So this will NOT delete the user's actual config directory. tier1/kconfig/autotests/kconfignokdehometest.cpp <http://git.reviewboard.kde.org/r/113422/#comment30807> Hehe kdehome doesn't exist anymore. This comment needs to be adjusted to say "the config dir" instead. tier1/kconfig/autotests/kconfigtest.cpp <http://git.reviewboard.kde.org/r/113422/#comment30808> Making extra extra sure? This is already set in initTestCase, there's not much point in setting it here again (no code ever calls it with false). But OK, if you want to avoid any risks :) - David Faure On Oct. 24, 2013, 3:55 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113422/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 3:55 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Port kconfigtest and kconfignokdehometest to QStandardPaths > > They relied on setting XDG_CONFIG_HOME which will not work on Windows > > > Diffs > ----- > > tier1/kconfig/autotests/kconfigtest.h > e0d7f7350159187e7611ddefd99d7d6faabde6ac > tier1/kconfig/autotests/kconfignokdehometest.cpp > ce53ca58fc7e1ce5a4345cce8a17de0e05866019 > tier1/kconfig/autotests/kconfigtest.cpp > 26e6a781bedf226ef0ca0d9030e107d3c412bd35 > > Diff: http://git.reviewboard.kde.org/r/113422/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
