> On Nov. 2, 2013, 8:27 a.m., David Faure wrote: > > Ship It! > > Alex Merry wrote: > Question: would it not make sense to put this in kde4support? > > David Faure wrote: > Sure, that's exactly the idea (I'll do that once this is committed) > > Alex Merry wrote: > I think I'd missed it was still in the "to be sorted" part of KIO :-) > > Related question: would it make sense to try to implement this by > directly enumerating the QImageIO plugins (and reading their JSON files)? > Possibly with some hacks for the built-in decoders. Because it looks to me > like we could then ditch the .desktop files for the plugins (including the > ones for Qt's own plugins/built-in code).
If we want to get rid of the .desktop files, why don't we just implement KImageIO on top of QImageReader/Writer, rather than duplicate its code? But in both cases we'll have an issue with the methods that work with old-style formats ("PNG") rather than mimetypes. Maybe it's simpler to just get rid of it all and force apps to port to QImageReader/Writer. Or just to keep the .desktop files for now :) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113510/#review42823 ----------------------------------------------------------- On Nov. 2, 2013, 7:04 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113510/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2013, 7:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > KImageIO functions can be deprecated in favor of QImageReader and > QImageWriter functionality. > > > Diffs > ----- > > kio/kio/kimageio.h cecadf1 > > Diff: http://git.reviewboard.kde.org/r/113510/diff/ > > > Testing > ------- > > it still builds. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel