----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/#review42956 -----------------------------------------------------------
Small nitpick, otherwise looks fine. tier2/kjobwidgets/src/kdialogjobuidelegate.cpp <http://git.reviewboard.kde.org/r/113516/#comment31023> What about using shared pointers? - Kevin Ottens On Oct. 31, 2013, 9:41 a.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113516/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 9:41 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Implement queueing directly in KDialogJobUiDelegate by queueing calls to > KDialogJobUiDelegate::Private::next which shows 1 KMessageBox at the time. > > > Diffs > ----- > > tier2/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae > tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 > > Diff: http://git.reviewboard.kde.org/r/113516/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
