> On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: > > It's going in the right direction, but I am wondering whether the > > Find*.cmake files should go to extra-cmake-modules instead of being part of > > the framework. You should add Steve (skelly) to the review to get his > > opinion.
Well, the idea was to have them all in extra-cmake-modules. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43202 ----------------------------------------------------------- On Nov. 6, 2013, 12:36 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113657/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 12:36 a.m.) > > > Review request for KDE Frameworks and Aurélien Gâteau. > > > Repository: kdelibs > > > Description > ------- > > Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when > building with DNSSD and factored out the Frameworks version. > > > Diffs > ----- > > cmake/modules/CMakeLists.txt 7910270 > cmake/modules/FindAvahi.cmake > cmake/modules/FindDNSSD.cmake 8604bd5 > tier2/dnssd/CMakeLists.txt 2cfcc40 > > Diff: http://git.reviewboard.kde.org/r/113657/diff/ > > > Testing > ------- > > 1. Configure with cmake > 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 > > Configures OK in both cases. Builds OK in case 1, does not build yet in case > 2. > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
