> On Nov. 9, 2013, 12:47 a.m., David Faure wrote: > > staging/kio/CMakeLists.txt, line 34 > > <http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line34> > > > > Why? KDED doesn't provide a library.
It provides a DBus interface (.xml) that is installed and later on used in kcookiejar to generate c++ code. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43285 ----------------------------------------------------------- On Nov. 8, 2013, 5:01 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113723/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 5:01 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > As you will see, this splitting was a bit harder than others: > - KIO was using a couple of private headers from kjobwidgets, which now they > will be installed. > - The xslt_kde target was being used from KDocTools without having it > exported. Now it will be properly exported. > - Also defines all dependencies so it can be compiled independently, > modularization is done as well. > > > Diffs > ----- > > tier2/kdoctools/src/CMakeLists.txt 3940e98 > tier2/kdoctools/KDocToolsConfig.cmake.in PRE-CREATION > tier2/kdoctools/KDocToolsConfig.cmake d501dc8 > tier2/kdoctools/CMakeLists.txt c2256ff > superbuild/CMakeLists.txt 458fb4c > tier1/kcoreaddons/src/lib/CMakeLists.txt fad55c5 > staging/kio/tests/CMakeLists.txt 6cee291 > staging/kio/src/widgets/CMakeLists.txt d90386d > staging/kio/src/ioslaves/http/tests/CMakeLists.txt 52c9f6c > staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt b0feff6 > staging/kio/src/ioslaves/help/CMakeLists.txt 40637dc > staging/kio/src/filewidgets/CMakeLists.txt 31fe8c6 > staging/kio/CMakeLists.txt 6c7297e > cmake/modules/FindGSSAPI.cmake > cmake/modules/CMakeLists.txt 7910270 > tier3/kded/KDEDConfig.cmake.in 32f8d56 > tier3/kservice/src/CMakeLists.txt cc0c1a4 > > Diff: http://git.reviewboard.kde.org/r/113723/diff/ > > > Testing > ------- > > Builds, Installs, tests still pass; both modularized and monolithic kdelibs. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel