----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113711/#review43370 -----------------------------------------------------------
This review has been submitted with commit f33e6dea79e3edcdd59c688c4d6f69d1c93a6cb1 by Alex Merry to branch frameworks. - Commit Hook On Nov. 7, 2013, 6:57 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113711/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 6:57 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > KPassivePopup had a bunch of odd public API that no-one was using because > it's useless to outside classes (even subclasses, of which there appear to be > none). This hides that away, and makes the protected stuff actually useful. > > There are still some issues with the "next to the taskbar" positioning (it > puts it alongside the entry instead of on the opposite side the screen edge), > but that's less urgent than the API change. > > > Clean up API of KPassivePopup > > Firstly, allow subclasses to more easily override the location: > * remove defaultArea from the public API, as it is useless to clients > * replace it with a virtual protected method defaultLocation > > Secondly, move other methods that should be private to the Private > class. > > Thirdly, remove the Custom entry from the PopupStyle enum as there is, > in practice, no easy way for subclasses to implement another style; by > the time they do, they may as well start from scratch. > > > Diffs > ----- > > tier2/knotifications/src/kpassivepopup.h > 4eb6ffc7b076391d3f74ce902cc964371b1046c8 > tier2/knotifications/src/kpassivepopup.cpp > f17086d3185e207b874f4dcfecf1da8715a3fd77 > > Diff: http://git.reviewboard.kde.org/r/113711/diff/ > > > Testing > ------- > > Still builds, test app still puts the popups where expected. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
