----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/#review44703 -----------------------------------------------------------
Looks fine to me. Makes me wonder if we want to drop the K for the target name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... - Kevin Ottens On Nov. 28, 2013, 1:46 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114182/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 1:46 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > This is just one framework - KConfig - if this is the proper way to do this, > I'll update this review with all frameworks updated to this. > > > Diffs > ----- > > tier1/kconfig/autotests/CMakeLists.txt cc2626b > tier1/kconfig/src/core/CMakeLists.txt c8a4842 > tier1/kconfig/src/gui/CMakeLists.txt b677d03 > tier1/kconfig/src/kconf_update/CMakeLists.txt 69668bc > > Diff: http://git.reviewboard.kde.org/r/114182/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
