----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114158/#review44713 -----------------------------------------------------------
This review has been submitted with commit e0e0efffb70b5c52fb8f010339c24cb695b4817f by David Edmundson to branch frameworks. - Commit Hook On Nov. 27, 2013, 6:02 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114158/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 6:02 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Use Sonnet::Decorator internally in KTextEdit > > In order to keep api compatibility we create a custom Sonnet::Decorator and > proxy the virtual methods. > The spellcheckdecorator event filter intercepts the context menu for > mispelled words our implementation will only be called for all other context > menu events. > > > Diffs > ----- > > tier3/ktextwidgets/src/widgets/ktextedit.h 2086607 > tier3/ktextwidgets/src/widgets/ktextedit.cpp f5d0331 > > Diff: http://git.reviewboard.kde.org/r/114158/diff/ > > > Testing > ------- > > I still have something wrong with my spell checker in KF5: > Aurélien tested for me, there appear to be some issues, such as not showing a > context menu until a language is set, but this seems to be independent from > this patch. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
