Hello, On Thursday 28 November 2013 17:53:14 Aleix Pol wrote: > I've seen that when we ask for a QFileDialog in KF5 we get a generic > QFileDialog at the moment. The reason is simple, KFileDialog is deprecated > in KDE4Support and we are not implementing > QPlatformDialogHelper *QPlatformThemecreatePlatformDialogHelper(DialogType > dialogType).
*And* KFileDialogQtOverride got moved in kde4support too. That's the reason why we used to get a KFileDialog for the static calls previously. Got broken during the move to kde4support. We shouldn't use that technique anymore though (covers only the static case and is rather intrusive IMO). So using a QPlatformDialogHelper is definitely the way forward. > I would like to make it happen, my only question is then what should we do? > Should we have a framework for KFileDialog, KColorDialog and KFontDialog? KColorDialog and KFontDialog are out of the picture. We contributed to the upstream QColorDialog and QFontDialog so that they have the features we needed out of the box. We only need to do something for the file dialog. > Should we fork them and get a copy in PlatformIntegration? Yes, we need something in the platform theme plugin. Be it a full fledged KFileDialog fork or a leaner QDialog which contains a KFileWidget I let you judge. I've a slight preference for composition (QDialog + KFileWidget), especially as the resulting class will be completely internal with no public API. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
