----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ -----------------------------------------------------------
(Updated Nov. 29, 2013, 11:30 a.m.) Review request for KDE Frameworks. Changes ------- Here's tier1/ done. I decided to do it by parts - first tier1, then adapt the rest of frameworks to tier1 changes, then change kde-workspace/runtime/plasma, then move to tier2, adapt, tier3, adapt etc. Everything build standalone except Sonnet, though I can't figure out why it fails (apparently can't find SONNECORE_EXPORT macro). Repository: kdelibs Description ------- This is just one framework - KConfig - if this is the proper way to do this, I'll update this review with all frameworks updated to this. Diffs (updated) ----- tier1/itemmodels/CMakeLists.txt d0be692 tier1/itemmodels/ItemModelsConfig.cmake.in 4ac98f3 tier1/itemmodels/KF5ItemModelsConfig.cmake.in PRE-CREATION tier1/itemmodels/autotests/CMakeLists.txt 03daf70 tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt 525c9f3 tier1/itemmodels/src/CMakeLists.txt 86b48cf tier1/itemviews/CMakeLists.txt 1bdadac tier1/itemviews/ItemViewsConfig.cmake.in 1956453 tier1/itemviews/KF5ItemViewsConfig.cmake.in PRE-CREATION tier1/itemviews/autotests/CMakeLists.txt 0219900 tier1/itemviews/src/CMakeLists.txt bad773c tier1/itemviews/tests/CMakeLists.txt 4ddf5d8 tier1/karchive/CMakeLists.txt f0d12ac tier1/karchive/KArchiveConfig.cmake.in 40fa614 tier1/karchive/KF5ArchiveConfig.cmake.in PRE-CREATION tier1/karchive/autotests/CMakeLists.txt a2cfabe tier1/karchive/examples/helloworld/CMakeLists.txt 2e90094 tier1/karchive/examples/tarlocalfiles/CMakeLists.txt b855caf tier1/karchive/src/CMakeLists.txt 767140a tier1/karchive/tests/CMakeLists.txt d804cd2 tier1/kcodecs/CMakeLists.txt a8217d0 tier1/kcodecs/KCodecsConfig.cmake.in ea632ce tier1/kcodecs/KF5CodecsConfig.cmake.in PRE-CREATION tier1/kcodecs/autotests/CMakeLists.txt bf393f8 tier1/kcodecs/src/CMakeLists.txt 152bc8e tier1/kconfig/CMakeLists.txt af91aa2 tier1/kconfig/KConfigConfig.cmake.in 5d9d7eb tier1/kconfig/KF5ConfigConfig.cmake.in PRE-CREATION tier1/kconfig/autotests/CMakeLists.txt cc2626b tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt 184ab17 tier1/kconfig/src/core/CMakeLists.txt c8a4842 tier1/kconfig/src/gui/CMakeLists.txt b677d03 tier1/kconfig/src/kconf_update/CMakeLists.txt 69668bc tier1/kconfig/src/kconfig_compiler/CMakeLists.txt 19d86d4 tier1/kcoreaddons/CMakeLists.txt 5d2b4a8 tier1/kcoreaddons/KCoreAddonsConfig.cmake.in a53be5f tier1/kcoreaddons/KF5CoreAddonsConfig.cmake.in PRE-CREATION tier1/kcoreaddons/autotests/CMakeLists.txt c804357 tier1/kcoreaddons/src/lib/CMakeLists.txt 638525f tier1/kcoreaddons/tests/CMakeLists.txt c79d0ba tier1/kdbusaddons/CMakeLists.txt 78cc443 tier1/kdbusaddons/KDBusAddonsConfig.cmake.in 27a6060 tier1/kdbusaddons/KF5DBusAddonsConfig.cmake.in PRE-CREATION tier1/kdbusaddons/autotests/CMakeLists.txt 92c9151 tier1/kdbusaddons/src/CMakeLists.txt 71dc290 tier1/kdbusaddons/tests/CMakeLists.txt 684fee3 tier1/kguiaddons/CMakeLists.txt b3f378d tier1/kguiaddons/KF5GuiAddonsConfig.cmake.in PRE-CREATION tier1/kguiaddons/KGuiAddonsConfig.cmake.in 83e4c91 tier1/kguiaddons/autotests/CMakeLists.txt 2e4a6bb tier1/kguiaddons/src/CMakeLists.txt ca94f4b tier1/kguiaddons/tests/CMakeLists.txt 754b460 tier1/kidletime/CMakeLists.txt 61ba25b tier1/kidletime/KF5IdleTimeConfig.cmake.in PRE-CREATION tier1/kidletime/KIdleTimeConfig.cmake.in ace9e8a tier1/kidletime/examples/CMakeLists.txt c88a6c3 tier1/kidletime/src/CMakeLists.txt 44a1f3f tier1/kjs/CMakeLists.txt ab27a14 tier1/kjs/KF5JSConfig.cmake.in PRE-CREATION tier1/kjs/KJSConfig.cmake.in 8c4ff9e tier1/kjs/autotests/CMakeLists.txt 206c17a tier1/kjs/src/kjs/CMakeLists.txt b63d92f tier1/kjs/src/kjs/api/CMakeLists.txt dadf39c tier1/kjs/tests/CMakeLists.txt 9388a70 tier1/kplotting/CMakeLists.txt f8e53ff tier1/kplotting/KF5PlottingConfig.cmake.in PRE-CREATION tier1/kplotting/KPlottingConfig.cmake.in 42d4fae tier1/kplotting/autotests/CMakeLists.txt cc03ea4 tier1/kplotting/examples/CMakeLists.txt 7c8ab7e tier1/kplotting/src/CMakeLists.txt 59e7d09 tier1/kwidgetsaddons/CMakeLists.txt 570630b tier1/kwidgetsaddons/KF5WidgetsAddonsConfig.cmake.in PRE-CREATION tier1/kwidgetsaddons/KWidgetsAddonsConfig.cmake.in 98dbc46 tier1/kwidgetsaddons/autotests/CMakeLists.txt 1f6b69f tier1/kwidgetsaddons/src/CMakeLists.txt 0333f3a tier1/kwidgetsaddons/tests/CMakeLists.txt 129504b tier1/kwindowsystem/CMakeLists.txt cebdf49 tier1/kwindowsystem/KF5WindowSystemConfig.cmake.in PRE-CREATION tier1/kwindowsystem/KWindowSystemConfig.cmake.in 49308aa tier1/kwindowsystem/autotests/CMakeLists.txt 92d4868 tier1/kwindowsystem/src/CMakeLists.txt f6e27ee tier1/kwindowsystem/tests/CMakeLists.txt fbf3d26 tier1/solid/CMakeLists.txt 6676410 tier1/solid/KF5SolidConfig.cmake.in PRE-CREATION tier1/solid/SolidConfig.cmake.in 16637e9 tier1/solid/autotests/CMakeLists.txt 8c46a1a tier1/solid/src/imports/CMakeLists.txt ac91736 tier1/solid/src/solid/CMakeLists.txt 024c7fa tier1/solid/tests/CMakeLists.txt 6bcf3cf tier1/sonnet/CMakeLists.txt bad6191 tier1/sonnet/KF5SonnetConfig.cmake.in PRE-CREATION tier1/sonnet/SonnetConfig.cmake.in 13dcfe4 tier1/sonnet/autotests/CMakeLists.txt c979842 tier1/sonnet/src/core/CMakeLists.txt 7aa41c0 tier1/sonnet/src/plugins/aspell/CMakeLists.txt e2d78b8 tier1/sonnet/src/plugins/enchant/CMakeLists.txt 9270833 tier1/sonnet/src/plugins/hspell/CMakeLists.txt b846ed4 tier1/sonnet/src/plugins/hunspell/CMakeLists.txt 0730284 tier1/sonnet/src/ui/CMakeLists.txt 2e2ef16 tier1/sonnet/tests/CMakeLists.txt 71d0ad6 tier1/threadweaver/CMakeLists.txt 61c2587 tier1/threadweaver/KF5ThreadWeaverConfig.cmake.in PRE-CREATION tier1/threadweaver/ThreadWeaverConfig.cmake.in bc116f0c tier1/threadweaver/autotests/CMakeLists.txt 9ae5b1d tier1/threadweaver/benchmarks/CMakeLists.txt 07f7875 tier1/threadweaver/src/Weaver/CMakeLists.txt d003e9f tier1/threadweaver/src/WeaverGui/CMakeLists.txt 4c4e1b2 Diff: http://git.reviewboard.kde.org/r/114182/diff/ Testing ------- Builds. Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel