> On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote: > > tier4/frameworkintegration/src/kstyle/kstyle.h, line 1518 > > <http://git.reviewboard.kde.org/r/114184/diff/2/?file=220988#file220988line1518> > > > > If you use Q_DECL_OVERRIDE, no need to repeat the virtual (applies to > > most of the methods in here).
I do like virtual, it is more syntax sugar and C++ developers are more use to it than to Q_DECL_OVERRIDE. I'd like to keep it but if you really want I can remove it. > On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote: > > tier4/frameworkintegration/src/kstyle/kstyle.h, line 1523 > > <http://git.reviewboard.kde.org/r/114184/diff/2/?file=220988#file220988line1523> > > > > Hmmm, I don't get that one... Which warning did you get? Because of the > > QApplication and QPalette overloads? Yes > On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote: > > tier4/frameworkintegration/src/kstyle/kstyle.cpp, line 373 > > <http://git.reviewboard.kde.org/r/114184/diff/2/?file=220989#file220989line373> > > > > Is it me or it's not needed anymore since the eventFilter method is > > gone? (not that it was doing anything meaningful previously). > > > > Even more so as you removed the removeEventFilter line from unpolish(). Yeah, I removed all of this but forgot this one :/ - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/#review44770 ----------------------------------------------------------- On Nov. 28, 2013, 6:20 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114184/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 6:20 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Removed everything from KStyle that is NOT about integrating with KDE. > > > Diffs > ----- > > tier4/frameworkintegration/src/kstyle/kstyle.h 4c83509 > tier4/frameworkintegration/src/kstyle/kstyle.cpp 626d2a9 > > Diff: http://git.reviewboard.kde.org/r/114184/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel