> On Dec. 28, 2013, 1:19 p.m., David Faure wrote: > > See, this will print an unnecessary (i.e. wrong) warning in case we *are* > > linking to KCoreAddons, but not using cmake. > > qmake users will have to add a define just to silence the warning. So this > > create more work, rather than helping... > > We'd have to ifdef the whole thing with a "if we are using cmake" define....
I deliberately set it up not to print the warning in that case - that's why it checks that KCOREADDONS_LIB is not defined AND that KGUIADDONS_LIB is defined. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/#review46273 ----------------------------------------------------------- On Dec. 28, 2013, 1:03 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114701/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2013, 1:03 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > ------- > > Print a warning if kimagecache.h is used without KF5::CoreAddons > > If an application links against KF5::GuiAddons but not KF5::CoreAddons, > they cannot use KImageCache. So we use defines (set by the exported > targets) to check whether the current target has been linked against > KF5::CoreAddons, and print a warning if not (to explain the expected > "kshareddatacache.h not found" error). > > > Diffs > ----- > > src/CMakeLists.txt d6ee3d9987319f9a3d1f8b2f66e00d2ec4bda1e5 > src/util/kimagecache.h 007891c757de9bedc5cf0c3b734e250004727ec4 > > Diff: https://git.reviewboard.kde.org/r/114701/diff/ > > > Testing > ------- > > plasma-framework (which uses KImageCache) still builds fine. If an older > version of KCoreAddons (without the KCOREADDONS_LIB define) is installed, a > warning is printed when kimagecache.h is included. If the patch in review > 114700 is applied to KCoreAddons, the warning is not printed. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel