Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/#review46352
-----------------------------------------------------------


The kde4 code (kcmdlineargs.cpp) was doing this:


           for (QList<KAboutPerson>::ConstIterator it = authors.begin(); it != 
authors.end(); ++it ) {
             QString email;
             if ( !(*it).emailAddress().isEmpty() )
               email = QString::fromLatin1(" &lt;") + (*it).emailAddress() + 
QLatin1String("&gt;");
             authorlist += QString::fromLatin1("    ") + (*it).name() + email + 
QLatin1Char('\n');
           }

Maybe the '<' and '>' should be re-added, and a space used instead of the tab?

- David Faure


On Dec. 29, 2013, 12:55 a.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114716/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2013, 12:55 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Without this patch, the parsing of "kgeography --author" gives:
> 
> kgeography was written by:
>    Albert Astals cidaa...@kde.org
> 
> With this patch:
> 
> kgeography was written by:
>    Albert Astals Cid    aa...@kde.org
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.cpp 3f08f25 
> 
> Diff: https://git.reviewboard.kde.org/r/114716/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>


_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel