----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114897/ -----------------------------------------------------------
Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description ------- Make KDE_ENABLE_EXCEPTIONS a list When KDE_ENABLE_EXCEPTIONS contains two arguments, they are currently a single string containing those space-separated arguments. It can thus be used as set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${KDE_ENABLE_EXCEPTIONS}") However, the proper way to set compile flags these days is to use add_compile_options, as in add_compile_options(${KDE_ENABLE_EXCEPTIONS}) which requires KDE_ENABLE_EXCEPTIONS to be a list. Note that this change means that setting CMAKE_CXX_FLAGS like above NO LONGER WORKS (as you will get the argument -fexceptions;-UQT_NO_EXCEPTIONS added for GCC and Clang). Diffs ----- kde-modules/KDECompilerSettings.cmake 72824e166d03dcc2d089814dc121f08ba998974a Diff: https://git.reviewboard.kde.org/r/114897/diff/ Testing ------- ThreadWeaver compiles under GCC on Linux if (and only if) I change the src/CMakeLists.txt file to use add_compile_options instead of setting CMAKE_CXX_FLAGS. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel