----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114888/#review47300 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Jan. 13, 2014, 10:17 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114888/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2014, 10:17 a.m.) > > > Review request for Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > When the RELATIVE parameter in ECMGenerateHeaders is empty or not set, the > _actualheader variable would be defined to > "/cmake/current/source/dir//lowercaseclassname.h". > > The double slash breaks RPM's debug symbols extraction, because it > canonicalizes the path, so it's shortened by one "/". The shortening is done > to avoid double-slash in the beginning of the path, which is non-POSIX. > However from my understanding it's not possible to truncate the size of > directory table by 1 byte, so the debugedit utility aborts and the entire > rpmbuild fails. See a relevant bug report with further information: > https://bugzilla.redhat.com/show_bug.cgi?id=304121 (comment #2) > > This patch simply makes sure that EGH_RELATIVE is either empty, or non-empty > and terminated with slash. > > With this patch we are able to build solid and kdnssd frameworks with RPM > build tools. > > > Diffs > ----- > > modules/ECMGenerateHeaders.cmake f72b1c0 > > Diff: https://git.reviewboard.kde.org/r/114888/diff/ > > > Testing > ------- > > Successfully built solid and kdnssd frameworks with rpmbuild, other > frameworks still build too. > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
