> On Jan. 11, 2014, 8:02 p.m., Alex Merry wrote: > > This should be using QT_REQUIRED_VERSION everywhere. Actually, if you > > could change it in the other CMakeLists.txt files, that would be good. > > Then it can be shipped. > > Michael Palimaka wrote: > No worries, will do. I only explicitly wrote the version for consistency > because pretty much every single framework hardcodes 5.2.0 in non-root > CMakeLists.txt
I think that happened because the variable was introduced later, and whoever did it didn't think that there might be find_package calls in subdirectories. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47231 ----------------------------------------------------------- On Jan. 11, 2014, 10:43 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114962/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2014, 10:43 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > QtTest and QtConcurrent are only required for autotests, so no need to find > them unconditionally. > QtWidgets is not actually used - QtGui is instead. > > > Diffs > ----- > > src/gui/CMakeLists.txt e6ef7468a1e736d5d0c0e601e24f961270f2d0f2 > autotests/CMakeLists.txt e4790f691f5a9ae2989faef742c31615713e0027 > CMakeLists.txt b794b4b35479525873c342e6a6aa6677b3f00513 > > Diff: https://git.reviewboard.kde.org/r/114962/diff/ > > > Testing > ------- > > Builds and tests pass without QtWidgets installed. Builds without QtTest and > QtConcurrent installed. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel