----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114990/#review47310 -----------------------------------------------------------
src/kauthactionreply.h <https://git.reviewboard.kde.org/r/114990/#comment33702> There is no such thing as kde5_add_executable(). Please have a look through http://community.kde.org/Frameworks/Porting_Notes for how the changes should actually be made. In particular, the first section (Build System) says how CMake calls are changed. In particular, there are *NO* cmake macros starting "kde5_". src/kauthactionreply.h <https://git.reviewboard.kde.org/r/114990/#comment33703> I'm sure no such macro exists. Have a look in kauth/cmake/KF5AuthMacros.cmake for what it should become. - Alex Merry On Jan. 12, 2014, 8:12 p.m., Siddharth Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114990/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2014, 8:12 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kauth > > > Description > ------- > > removing kde4 references from kauth > > > Diffs > ----- > > src/kauthactionreply.h a7d2020 > > Diff: https://git.reviewboard.kde.org/r/114990/diff/ > > > Testing > ------- > > none > > > Thanks, > > Siddharth Sharma > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
