----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209/#review47997 -----------------------------------------------------------
Would it be possible to unify the two "add_custom_command" by redefining only docbookl10nhelper_EXE into the WIN32 block? Could you please add the kdewin group as reviewers so that they can check if it works with gcc too? - Luigi Toscano On Jan. 22, 2014, 1:26 a.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115209/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 1:26 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > Two separate commits: > > ----------------------------------- > > Print a message when a file is not found > > This way meinproc no longer fails silently > > ---------------------------------- > > Allow compiling on Windows with MSVC > > > Diffs > ----- > > CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 > src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b > src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 > src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade > src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 > > Diff: https://git.reviewboard.kde.org/r/115209/diff/ > > > Testing > ------- > > Works on windows once https://git.reviewboard.kde.org/r/115210/ is also > applied > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel