----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/#review48094 -----------------------------------------------------------
Ship it! Looks good to me. Just a nitpick, feel free to commit when it is fixed. src/kapidox/__init__.py <https://git.reviewboard.kde.org/r/115165/#comment34040> nitpick: add a space before "doxyfile_path". Issue was already there, but since you are touching this line, let's fix it. - Aurélien Gâteau On Jan. 21, 2014, 2:52 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115165/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 2:52 p.m.) > > > Review request for KDE Frameworks and Aurélien Gâteau. > > > Repository: kapidox > > > Description > ------- > > Use a proper temporary file for the doxygen config > > > Diffs > ----- > > src/kapidox/__init__.py 554bd2412dfa8c279a78c969de765d36b51236ba > > Diff: https://git.reviewboard.kde.org/r/115165/diff/ > > > Testing > ------- > > Ran kgenapidox on threadweaver with both python2 and python3. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel