apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > ahmadsamir wrote in kuitmarkup.cpp:412 > According to the QList docs, at() should be used for read-only access, it > could be faster than [] and it never causes a detach. I'd do these changes in a separate commit. Also adding consts to unrelated variables. REPOSITORY R249 KI18n BRANCH l-toKeyCombo (branched from master) REVISION DETAIL https://phabricator.kde.org/D26360 To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid, apol Cc: apol, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
