bruns added a comment.
I have thought about this and have come to the conclusion this is not really
future proof.
The `Property::FrontCover` is IMHO fine, i.e. the changes to
`propertyinfo.cpp` and `properties.h` could go in as is.
The request of additional properties should be done differently. How about
the following:
1. divide properties into (currently) two sets, "Simple Metadata" (all the
current ones but frontcover) and "Complex Metadata" (currently frontcover).
2. allow to specify extra properties for SimpleExtractionResult
SimpleExtractionResult result(fileName, mimeType);
result.setExtraProperties({Property::FrontCover});
plugin.extract(&result);
You can then also do:
SimpleExtractionResult result(fileName, mimeType,
ExtractionResult::ExtractNothing);
result.setExtraProperties({Property::FrontCover, Property::BandLogo});
plugin.extract(&result);
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D25517
To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
