elvisangelaccio added inline comments. INLINE COMMENTS
> renamefiledialog.h:48 > + */ > +// TODO KF6 : rename the class RenameFileDialog to RenameDialog and the > class RenameFileDialog to RenameFileOverwrittenDialog or similar. > +class KIOWIDGETS_EXPORT RenameFileDialog : public QDialog So, what should we rename `RenameFileDialog` to? `RenameFileDialog` or `RenameFileOverwrittenDialog` ? ;) Anyway, why wait for KF6 since this is new API? Can't we rename it now? REPOSITORY R241 KIO BRANCH arcpatch-D17595_1 REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham
