dfaure added inline comments.

INLINE COMMENTS

> mlaurent wrote in kconfig_compiler.cpp:694
> I think that it was a problem when QTextStream used QString which doesn't 
> flush it.
> code is a QString

I think you're confusing two cases.

The "underlying device" goes away before the QTextStream ==> this only works 
when the device is a proper QIODevice, while a QString has no "closed 
notification".

The QTextStream goes away before the underlying device. No problem in either 
case, the QTextStream destructor flushes.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26432

To: mlaurent, dfaure, tcanabrava
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Reply via email to