dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Almost there.
Please add @since 5.67 to the new enum and the new methods.
INLINE COMMENTS
> dfaure wrote in dropjob.cpp:416
> This '{' goes on its own line.
Not fixed.
> dropjob.h:147
>
> +KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl
> &destUrl, DropJobFlags dropjobFlags, JobFlags flags = DefaultFlags); // BCI:
> merge wih DropJobFlags dropjobFlag = DropJobDefaultFlag
> +
Please document this method (copy/pasting is OK)
And add @since 5.67
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26484
To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,
michaelh, bruns
